Populate the Voq system Port information for the local port when the Port is removed and created when the Speed is changed dynamically via GCU #3976
+165
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Port is removed and created when the Speed is changed dynamically via GCU Signed-off-by: saksarav <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@arlakshm @vmittal-msft @deepak-singhal0408 @rlhui |
…e front panel port so the removePort will be successful Signed-off-by: saksarav <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: saksarav <[email protected]>
saksarav-nokia
force-pushed
the
saksarav-nokia-GCU-system-port
branch
from
3d8f622 to
29019f9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Thanks @saksarav-nokia . Solution looks good to me. |
saksarav-nokia
requested review from
abdosi,
judyjoseph and
prsunny
as code owners
Contributor
Author
|
Verified the fix also in master |
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
deepak-singhal0408
approved these changes
Nov 12, 2025
Contributor
Author
|
Created Azure/sonic-swss.msft#167 for msft-2405 |
arlakshm
approved these changes
Nov 14, 2025
prsunny
reviewed
Nov 17, 2025
| return; | ||
| } | ||
|
|
||
| if ((gMySwitchType == "voq") && (port.m_type == Port::PHY)) |
Collaborator
There was a problem hiding this comment.
This may need to be addressed as per this PR - #3847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
What I did
Fixed the issue reported in sonic-net/sonic-buildimage#24417
Added code to populate the system_port information in the New Port structure in orchagent portsorch after the Port is removed and created when the Port speed is changed via GCU patch.
Why I did it
When the switch is created, swss queries all the SYSTEM_PORTS from SAI and updates the PORT class/structure with the corresponding system_port info after the PortInitDone event is received from portsyncd.
Then the port speed is changed with 4 Lanes via GCU patch, the port is removed from SAI and created again in swss by calling deInitPort and initPort. But in initPort, the system_port info is not updated in the new PORT structure.
So when the RIF is created on local interface, the voqSyncAddIntf adds an entry in SYSTEM_INTERFACE table in CHASSIS_APP_DB with empty key since the system_port info is not populated for the local port. For the same reason, the SYSTEM_NEIGH info is also not updated in CHASSIS_APP_DB. This breaks the basic VOQ functionality
How I verified it
Verified that the VOQ functionality works as expected with the traffic with multi-asic after the GCU patch
Details if related